[cxx-interop] Synthesize conformances to CxxSequence
#60332
Merged
+211
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
zoecarver
reviewed
Aug 1, 2022
zoecarver
approved these changes
Aug 1, 2022
egorzhdan
force-pushed
the
egorzhdan/cxx-synthesize-sequence
branch
2 times, most recently
from
eac5418 to
e29288d
Compare
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/cxx-synthesize-sequence
branch
from
e29288d to
01797c5
Compare
|
@swift-ci please smoke test |
egorzhdan
force-pushed
the
egorzhdan/cxx-synthesize-sequence
branch
from
01797c5 to
09b8d73
Compare
|
@swift-ci please smoke test |
This makes ClangImporter automatically conform C++ sequence types to `Cxx.CxxSequence` protocol. We consider a C++ type to be a sequence type if it defines `begin()` & `end()` methods that return iterators of the same type which conforms to `UnsafeCxxInputIterator`.
egorzhdan
force-pushed
the
egorzhdan/cxx-synthesize-sequence
branch
from
09b8d73 to
e3a3217
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes ClangImporter automatically conform C++ sequence types to
Cxx.CxxSequenceprotocol.We consider a C++ type to be a sequence type if it defines
begin()&end()methods that return iterators of the same type which conforms toUnsafeCxxInputIterator.